Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config file for readthedocs #935

Merged
merged 1 commit into from
May 6, 2023

Conversation

SeverinDiederichs
Copy link
Member

Similar to ECP-WarpX/WarpX#3896 for fixing the required newer OpenSSL version.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added the documentation Improvements or additions to documentation label May 6, 2023
@SeverinDiederichs SeverinDiederichs requested a review from ax3l May 6, 2023 19:58
@ax3l ax3l merged commit 07f0a91 into Hi-PACE:development May 6, 2023
@ax3l
Copy link
Member

ax3l commented May 6, 2023

Thank you! Doc builds are green again:)

@SeverinDiederichs SeverinDiederichs deleted the fix_RTD branch May 6, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants